app-autoscaler-release icon indicating copy to clipboard operation
app-autoscaler-release copied to clipboard

Make doesn't fail on error

Open marcinkubica opened this issue 2 years ago • 0 comments

Make doesn't fail on error

It appears make doesn't fail on error for Github Actions

Run make build
  make build
  shell: /usr/bin/bash -e {0}
  env:
    DB_DATABASE: autoscaler
    DB_USER: postgres
    DB_PASSWORD: postgres
    MAVEN_VERSION: 3.6.3
    MAVEN_SHA: c35a1803a6e70a1[2](https://github.com/cloudfoundry/app-autoscaler-release/actions/runs/3765529443/jobs/6401105984#step:6:2)6e80b2b[3](https://github.com/cloudfoundry/app-autoscaler-release/actions/runs/3765529443/jobs/6401105984#step:6:3)ae33eed961f83ed7[4](https://github.com/cloudfoundry/app-autoscaler-release/actions/runs/3765529443/jobs/6401105984#step:6:4)d18fcd16909b2d44d7dada3203f1ffe726c17ef8dcca2dcaa9fca676987befeadc9b9f7[5](https://github.com/cloudfoundry/app-autoscaler-release/actions/runs/3765529443/jobs/6401105984#step:6:5)99[6](https://github.com/cloudfoundry/app-autoscaler-release/actions/runs/3765529443/jobs/6401105984#step:6:6)[7](https://github.com/cloudfoundry/app-autoscaler-release/actions/runs/3765529443/jobs/6401105984#step:6:7)a[8](https://github.com/cloudfoundry/app-autoscaler-release/actions/runs/3765529443/jobs/6401105984#step:6:8)cb77181c0
    JAVA_HOME: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.5-8/x64
    JAVA_HOME_17_X64: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.5-8/x64
/bin/bash: line 1: ginkgo: command not found
# Installing build tools
# building api
# building eventgenerator

Your environment

Current ubuntu-latest job Please see workflow log

Fixes

Problem doesn't appear when using app-autoscaler-release-tools image (since ginkgo is present there) however the issue not failing the workflow persist.

marcinkubica avatar Dec 23 '22 16:12 marcinkubica