kubecf icon indicating copy to clipboard operation
kubecf copied to clipboard

Allow the user to define CATs tests to run or to not run

Open qu1queee opened this issue 5 years ago • 3 comments

Is your feature request related to a problem? Please describe. Yes, there is no flexibility during run time(installation/upgrade) to define the CATs test to run.

Describe the solution you'd like A feature flag that can hold a list of test to skip or to run

Describe alternatives you've considered None

Additional context None

qu1queee avatar Apr 01 '20 10:04 qu1queee

We can extend: https://github.com/cloudfoundry-incubator/kubecf/blob/2cf693c261b95fbb5f32e56f392876b8bea30390/deploy/helm/kubecf/values.yaml#L311-L319

instead of adding another feature flag. For now, you can achieve that with:

properties:
  acceptance-tests:
    acceptance-tests:
      acceptance_tests:
        include: '=ssh'
        ginkgo:
          nodes: 12
          extra_flags: -v
          flake_attempts: 2

(I added the ginkgo key above as an example of how to also tweak it)

f0rmiga avatar Apr 01 '20 16:04 f0rmiga

@f0rmiga ok, seems then this issue is obsolete, pls feel free to close it. The ginkgo is not documented anywhere, shall we?

qu1queee avatar Apr 06 '20 13:04 qu1queee

I'll reopen this and suggest creating the specific keys under the following, as I mentioned on my previous message: https://github.com/cloudfoundry-incubator/kubecf/blob/2cf693c261b95fbb5f32e56f392876b8bea30390/deploy/helm/kubecf/values.yaml#L311-L319

@fargozhu If you could schedule this soon, it should be quick to implement.

f0rmiga avatar Apr 08 '20 18:04 f0rmiga