cf icon indicating copy to clipboard operation
cf copied to clipboard

`cf push --reset` does not forget custom command

Open dsyer opened this issue 11 years ago • 9 comments

If I push an app with a custom command in the manifest and then subsequently delete that command from the manifest cf push still uses it, even if I use --reset. the only way to recover seems to be the delete the app and start again (losing all env and service settings).

dsyer avatar Aug 19 '13 12:08 dsyer

:+1:

andypiper avatar Aug 19 '13 14:08 andypiper

Hi @dsyer,

Our guess is that the cloud controller isn't clearing out the custom command from its database, so removing it from the manifest is not enough. Have you tried setting it to a null command like 'none' or '~'? This might clear out the field in the CCDB so the app gets the proper startup command.

Nevertheless, this sounds like a bug, and we can ping the runtime team about prioritizing it.

@dsabeti and @d

dsabeti avatar Aug 20 '13 17:08 dsabeti

Looping in @MarkKropf so he can add a story

xoebus avatar Aug 30 '13 17:08 xoebus

Tried 'null', '~' and empty but none worked to clear the custom command.

dsyer avatar Sep 02 '13 09:09 dsyer

I've added a story in our backlog to get this addressed, thanks for reporting it @dsyer

MarkKropf avatar Sep 04 '13 18:09 MarkKropf

Adding my +1 from running into this issue today.

bklang avatar Oct 02 '13 20:10 bklang

I also have just run into this now while following http://docs.cloudfoundry.com/docs/using/deploying-apps/migrate-db.html

Will this be addressed in the next release?

wayneeseguin avatar Nov 01 '13 02:11 wayneeseguin

for the status of this, you can follow along here: http://cftracker.cfapps.io/runtime

the story named "cf push reset doesnt forget custom command" and having the id 56378166 is a ways down in the backlog, but it is prioritized out of the icebox.

jbayer avatar Nov 02 '13 18:11 jbayer

We just committed to Cloud Controller some code that will accept a command of an empty string and treat it as the default command for that buildpack.

There were some hairy implementation details preventing us from cleanly accepting a null value for default command, so unfortunately if you send command: null, the Cloud Controller will ignore the command part altogether.

I think this bug is still open for cf, but the new workaround is to have command: "" in your manifest file. I expect this change to be included in cf-release v148, which we will hopefully deploy next week.

mark-rushakoff avatar Nov 06 '13 22:11 mark-rushakoff