bosh-init uses template name as job name

[mtekel]

When you define

jobs:
- name: myjob
  templates:
  - name: mypackage
    release: release1

Then <%= name %> in erb template of the mypackage will be mypackage instead of myjob. For example in case of collectd, your VM will send metrics as collectd instead of myjob. This is quite confusing, especially if you deploy multiple servers with bosh-init and they all end up with same name in their job configs...

bosh-init versions 0.0.95 and 0.0.80 - both have this behaviour.

[cppforlife]

@mtekel yup looks like a bug. should be instance group's name.

[dpb587-pivotal]

I'd guess NewEvaluationContext should be receiving an Instance and using Instance.JobName() for Name instead. Doesn't seem like this fix would be affected by CLI-related changes and could be safely PR'd to bosh-init and later merged to cli branch.