wrangler-action icon indicating copy to clipboard operation
wrangler-action copied to clipboard

Feature request: Support for preview comment.

Open NorbertBodziony opened this issue 3 years ago • 18 comments

Would love to get support for preview comment after successful deployment. Something like this https://github.com/BetaHuhn/deploy-to-vercel-action for vercel.

NorbertBodziony avatar Jun 09 '22 16:06 NorbertBodziony

Or maybe like Cloudflare Pages?

example: https://github.com/NullVoxPopuli/ember-resources/pull/529

image

NullVoxPopuli avatar Jun 12 '22 14:06 NullVoxPopuli

Yes please! This feature would be awesome. Or even a way for us to construct that message via exported values. This Action currently takes inputs but does not save any outputs.

I tried to manually construct this message by saving the .stdout of this Action but no luck. This feature would be greatly appreciated

GrantBirki avatar Jun 24 '22 00:06 GrantBirki

Came here to request this feature. Even some output from this action would be awesome so we could create our own comments

adam-clio avatar Sep 07 '22 17:09 adam-clio

Hate to be "that guy", but can we get a bumpbump on this bad boy? Kinda makes this action worthless for PR deploys at this point.

Also, seems related to #90 #81

danawoodman avatar Mar 23 '23 20:03 danawoodman

Hey @JacobMGEvans can you provide more info why this issue has been closed ?

NorbertBodziony avatar Aug 08 '23 08:08 NorbertBodziony

I closed them all (https://github.com/cloudflare/wrangler-action/discussions/122), this sounds like a great idea. Will revisit it, thanks for the follow up!

JacobMGEvans avatar Aug 08 '23 13:08 JacobMGEvans

If it Pages related I suggest this comment as well to help https://github.com/cloudflare/wrangler-action/issues/65#issuecomment-1670136345

JacobMGEvans avatar Aug 08 '23 20:08 JacobMGEvans

It would be great if wrangler action would provide the same bot functionality as shown by the OP.

hellt avatar Jul 25 '24 10:07 hellt

I did this myself like so:

  • https://github.com/unicode-org/cldr/blob/9597d2390dfe66b8a892d7ec60543c3e6007c6f3/.github/workflows/site.yml#L49-L58
  • PR: https://github.com/unicode-org/cldr/pull/3989

Hope it helps.

srl295 avatar Aug 27 '24 22:08 srl295

This is sweet, thanks @srl295 The missing piece, though, is having an alias with the branch name, which seems to be totally gone when the static artifacts are pushed via wrangler and not via the direct repo integration

hellt avatar Aug 28 '24 08:08 hellt

This is sweet, thanks @srl295 The missing piece, though, is having an alias with the branch name, which seems to be totally gone when the static artifacts are pushed via wrangler and not via the direct repo integration

I'm not 24 hours into my integration at this point, so.. I don't quite follow what you mean. You want "mysite-mybranch.pages.dev" or something? I don't quite see how that's part of this issue - that sounds like an option on the upload side?

srl295 avatar Aug 28 '24 15:08 srl295

You want "mysite-mybranch.pages.dev" or something? I don't quite see how that's part of this issue - that sounds like an option on the upload side?

Yes, this is about Branch Prefiew URL as shown in https://github.com/cloudflare/wrangler-action/issues/77#issuecomment-1153183792

I agree, it might be considered not related to the request of having ability for an action to post a comment, if we only consider comment to have a hash-based preview URL that is visible in the action output.

hellt avatar Aug 28 '24 15:08 hellt

the current action produces a single URL as output. So it seems like something else is needed if you want a different URL. Maybe you should file a separate issue for it?

srl295 avatar Aug 28 '24 15:08 srl295

I'm also looking for this feature. I had no choice but to write my own workflow, so there's no problem, but if it's officially supported, that would be best.

image

mfyuu avatar Nov 13 '24 13:11 mfyuu

still with no update here? for almost 3 years?..

kleinpetr avatar Nov 26 '24 14:11 kleinpetr

I just added an action to easily view the preview url using the same format as @namidapoo. https://github.com/marketplace/actions/comment-cloudflare-preview-url-on-pr Someone wants to help me to test if it's easy to use for anyone?

moojing avatar Jan 30 '25 22:01 moojing