re-enable vite-plugin remote bindings e2e tests

[dario-piotrowicz]

Fixes https://jira.cfdata.org/browse/DEVX-1953

---

• Tests
  • [ ] TODO (before merge)
  • [x] Tests included
  • [ ] Tests not necessary because:
• Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
  • [ ] I don't know
  • [x] Required
  • [ ] Not required because:
• Public documentation
  • [ ] TODO (before merge)
  • [ ] Cloudflare docs PR(s):
  • [x] Documentation not necessary because: tests-only change
• Wrangler V3 Backport
  • [ ] TODO (before merge)
  • [ ] Wrangler PR:
  • [x] Not necessary because: update related to a non-v3 feature

[changeset-bot[bot]]

⚠️ No Changeset found

Latest commit: 7ec807ad85fdb001469301b72581b01217464077

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[pkg-pr-new[bot]]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9652

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9652

miniflare

npm i https://pkg.pr.new/miniflare@9652

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9652

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9652

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9652

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9652

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9652

wrangler

npm i https://pkg.pr.new/wrangler@9652

commit: 4c8c87e

[dario-piotrowicz]

I think we should also skip remote bindings tests if there is no CLOUDFLARE_API_TOKEN. That way we won't block forked PRs.

We are: https://github.com/cloudflare/workers-sdk/pull/9652/files#diff-d9b32f69a202cbf69dc77c2777a78758abe37967f4015456c65d005d6117c33dR21

Are we not? 🤔

[dario-piotrowicz]

Also I am worried that this will make our CI even more flakey, since remote mode has been problematic.

That's totally fair... if you prefer we can hold off on this change

[petebacondarwin]

Also I am worried that this will make our CI even more flakey, since remote mode has been problematic.

That's totally fair... if you prefer we can hold off on this change

Nah! Let's do it.