workers-sdk icon indicating copy to clipboard operation
workers-sdk copied to clipboard

[DO NOT MERGE] MQ-667: add queues update sub command

Open TaraGarg opened this issue 1 year ago • 10 comments

What this PR solves / how to test

Fixes https://jira.cfdata.org/browse/MQ-667

Author has addressed the following

  • Tests
    • [ ] TODO (before merge)
    • [x] Included
    • [ ] Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • [x] I don't know
    • [ ] Required / Maybe required
    • [ ] Not required because:
  • Changeset (Changeset guidelines)
    • [ ] TODO (before merge)
    • [x] Included
    • [ ] Not necessary because:
  • Public documentation
    • [ ] TODO (before merge)
    • [x] Cloudflare docs PR(s): https://github.com/cloudflare/cloudflare-docs/pull/16080
    • [ ] Not necessary because:

TaraGarg avatar Aug 08 '24 18:08 TaraGarg

🦋 Changeset detected

Latest commit: b56321b039987ee98a48a6372bf704639e3a6ec8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Aug 08 '24 18:08 changeset-bot[bot]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10407109554/npm-package-wrangler-6450

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6450/npm-package-wrangler-6450

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10407109554/npm-package-wrangler-6450 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10407109554/npm-package-create-cloudflare-6450 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10407109554/npm-package-cloudflare-kv-asset-handler-6450
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10407109554/npm-package-miniflare-6450
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10407109554/npm-package-cloudflare-pages-shared-6450
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10407109554/npm-package-cloudflare-vitest-pool-workers-6450
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10407109554/npm-package-cloudflare-workers-editor-shared-6450
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10407109554/npm-package-cloudflare-workers-shared-6450

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240806.0
workerd 1.20240806.0 1.20240806.0
workerd --version 1.20240806.0 2024-08-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

github-actions[bot] avatar Aug 08 '24 18:08 github-actions[bot]

can update this to use the PATCH endpoint once it is merged & released

Do you mean once the API has this endpoint? Or once this PR here is merged?

petebacondarwin avatar Aug 13 '24 15:08 petebacondarwin

can update this to use the PATCH endpoint once it is merged & released

Do you mean once the API has this endpoint? Or once this PR here is merged?

once the API has this endpoint

w-kuhn avatar Aug 13 '24 17:08 w-kuhn

can update this to use the PATCH endpoint once it is merged & released

Do you mean once the API has this endpoint? Or once this PR here is merged?

once the API has this endpoint

@w-kuhn is there a timeline for this? Can this wrangler PR land before that API endpoint is up in prod?

CarmenPopoviciu avatar Aug 15 '24 07:08 CarmenPopoviciu

can update this to use the PATCH endpoint once it is merged & released

Do you mean once the API has this endpoint? Or once this PR here is merged?

once the API has this endpoint

@w-kuhn is there a timeline for this? Can this wrangler PR land before that API endpoint is up in prod?

This PR should land asap. Updating to use the new endpoint should happen as a fast follow.

w-kuhn avatar Aug 15 '24 11:08 w-kuhn

can update this to use the PATCH endpoint once it is merged & released

But don't block this PR on that.

w-kuhn avatar Aug 15 '24 11:08 w-kuhn

can update this to use the PATCH endpoint once it is merged & released

Do you mean once the API has this endpoint? Or once this PR here is merged?

once the API has this endpoint

@w-kuhn is there a timeline for this? Can this wrangler PR land before that API endpoint is up in prod?

We are now waiting to make message expiration for queues available to everyone before we merge these wrangler CLI changes since we don't have something like a gate to only allow certain accounts in the workers-sdk changes.

TaraGarg avatar Aug 15 '24 15:08 TaraGarg

can update this to use the PATCH endpoint once it is merged & released

Do you mean once the API has this endpoint? Or once this PR here is merged?

once the API has this endpoint

@w-kuhn is there a timeline for this? Can this wrangler PR land before that API endpoint is up in prod?

We are now waiting to make message expiration for queues available to everyone before we merge these wrangler CLI changes since we don't have something like a gate to only allow certain accounts in the workers-sdk changes.

@TaraGarg so should I hold off merging these changes?

CarmenPopoviciu avatar Aug 15 '24 16:08 CarmenPopoviciu

can update this to use the PATCH endpoint once it is merged & released

Do you mean once the API has this endpoint? Or once this PR here is merged?

once the API has this endpoint

@w-kuhn is there a timeline for this? Can this wrangler PR land before that API endpoint is up in prod?

We are now waiting to make message expiration for queues available to everyone before we merge these wrangler CLI changes since we don't have something like a gate to only allow certain accounts in the workers-sdk changes.

@TaraGarg so should I hold off merging these changes?

Yes please!

TaraGarg avatar Aug 15 '24 16:08 TaraGarg

Sounds like this is not ready to go, so moving to draft

penalosa avatar Nov 12 '24 23:11 penalosa

Rebased and opened up a new PR here: https://github.com/cloudflare/workers-sdk/pull/8120 This one can be closed (I don't have permissions to do that)

sdnts avatar Feb 12 '25 19:02 sdnts