workers-sdk icon indicating copy to clipboard operation
workers-sdk copied to clipboard

Add python support for remote dev

Open garrettgu10 opened this issue 1 year ago • 3 comments

This PR makes sure that the bundle type is set correctly in remote dev mode when the main module is a Python module. It also ensures that the source URL annotation is written in Python style when the entry point is a Python module.

Author has addressed the following:

  • Tests
    • [ ] Included
    • [x] Not necessary because: one-line change on experimental feature
  • Changeset (Changeset guidelines)
    • [x] Included
    • [ ] Not necessary because:
  • Associated docs
    • [ ] Issue(s)/PR(s):
    • [x] Not necessary because: one-line change on experimental feature; we will also be writing docs for the feature in the near future.

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

garrettgu10 avatar Feb 28 '24 22:02 garrettgu10

🦋 Changeset detected

Latest commit: ba75bbdfe6f3ace0b91ab8fd165648eedbe416d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Feb 28 '24 22:02 changeset-bot[bot]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8116146256/npm-package-wrangler-5119

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5119/npm-package-wrangler-5119

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8116146256/npm-package-wrangler-5119 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8116146256/npm-package-create-cloudflare-5119 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8116146256/npm-package-cloudflare-kv-asset-handler-5119
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8116146256/npm-package-miniflare-5119
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8116146256/npm-package-cloudflare-pages-shared-5119
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8116146256/npm-package-cloudflare-vitest-pool-workers-5119

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240223.0
workerd 1.20240223.1 1.20240223.1
workerd --version 1.20240223.1 2024-02-23

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

github-actions[bot] avatar Feb 28 '24 22:02 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.37%. Comparing base (54f6bfc) to head (ba75bbd). Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5119      +/-   ##
==========================================
+ Coverage   70.33%   70.37%   +0.03%     
==========================================
  Files         298      298              
  Lines       15515    15543      +28     
  Branches     3987     4000      +13     
==========================================
+ Hits        10913    10938      +25     
- Misses       4602     4605       +3     
Files Coverage Δ
...kages/wrangler/src/deployment-bundle/source-url.ts 57.89% <100.00%> (+2.33%) :arrow_up:
packages/wrangler/src/dev/remote.tsx 11.73% <ø> (+3.81%) :arrow_up:

... and 11 files with indirect coverage changes

codecov[bot] avatar Feb 28 '24 23:02 codecov[bot]