workers-sdk icon indicating copy to clipboard operation
workers-sdk copied to clipboard

Python playground support

Open penalosa opened this issue 1 year ago • 4 comments

Fixes # [insert GH or internal issue number(s)].

What this PR solves / how to test:

Go to https://8f2e7cec.workers-playground.pages.dev/playground/python and you should be able to try it out! (the first time you visit you might get a "Valid token must be provided" error—just reload the page. Cookies are a bit funny in the preview deployments)

Author has addressed the following:

  • Tests
    • [ ] Included
    • [x] Not necessary because: No tests have been added for the python functionality, since it's not yet stable enought to test realiably. There should be no affect on the JS functionality
  • Changeset (Changeset guidelines)
    • [ ] Included
    • [x] Not necessary because: Not relevant
  • Associated docs
    • [ ] Issue(s)/PR(s):
    • [x] Not necessary because: Not at a stage for docs

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

penalosa avatar Feb 16 '24 20:02 penalosa

🦋 Changeset detected

Latest commit: 5be7125626743b18eb6fa0927999477ac433c857

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
playground-preview-worker Patch
workers-playground Patch
workers.new Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Feb 16 '24 20:02 changeset-bot[bot]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8191776021/npm-package-wrangler-5043

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5043/npm-package-wrangler-5043

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8191776021/npm-package-wrangler-5043 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8191776021/npm-package-create-cloudflare-5043 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8191776021/npm-package-cloudflare-kv-asset-handler-5043
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8191776021/npm-package-miniflare-5043
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8191776021/npm-package-cloudflare-pages-shared-5043
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8191776021/npm-package-cloudflare-vitest-pool-workers-5043

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240223.1
workerd 1.20240304.0 1.20240304.0
workerd --version 1.20240304.0 2024-03-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

github-actions[bot] avatar Feb 16 '24 20:02 github-actions[bot]

🙌 🔥

irvinebroque avatar Feb 16 '24 20:02 irvinebroque

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.36%. Comparing base (2713977) to head (5be7125). Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5043   +/-   ##
=======================================
  Coverage   70.35%   70.36%           
=======================================
  Files         298      298           
  Lines       15567    15567           
  Branches     4007     4007           
=======================================
+ Hits        10952    10953    +1     
+ Misses       4615     4614    -1     

see 4 files with indirect coverage changes

codecov[bot] avatar Feb 16 '24 20:02 codecov[bot]

Should we merge so that can start playing with this in production, etc? And then layer on other options as discussed in designs in separate PR?

irvinebroque avatar Mar 05 '24 02:03 irvinebroque