workers-sdk icon indicating copy to clipboard operation
workers-sdk copied to clipboard

move `patchConfig` tests from wrangler to workers-utils, also add wrangler-config testing utils to workers-utils/test-helpers

Open dario-piotrowicz opened this issue 4 weeks ago • 1 comments

The patchConfig utility is defined in the workers-utils package but is tested in the wrangler package instead. I do believe that the tests should live in the same package implementing the utility so I am moving them here.

Those tests require the writeWranglerConfig, writeDeployRedirectConfig, writeRedirectedWranglerConfig and readWranglerConfig testing utilities so I am moving those under workers-utils/test-helpers.

[!Note] This is the same sort of change as https://github.com/cloudflare/workers-sdk/pull/11539. Besides patchConfig (as far as I can tell) there is only one more instance of a worker-utils utility being tested in wrangler validatePagesConfig I'm happy to also move those tests but I wanted to keep thing simple/separate and just focus on the patchConfig tests in this PR


  • Tests
    • [x] Tests included/updated
    • [ ] Tests not necessary because:
  • Public documentation
    • [ ] Cloudflare docs PR(s):
    • [x] Documentation not necessary because: internal change + workers-utils don't have docs
  • Wrangler V3 Backport
    • [ ] Wrangler PR:
    • [x] Not necessary because: workers-utils are not in the v3 branch

A picture of a cute animal (not mandatory, but encouraged)

dario-piotrowicz avatar Dec 12 '25 00:12 dario-piotrowicz

🦋 Changeset detected

Latest commit: f01b3c68812e8d6023307c286d3db547bb0b9418

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Dec 12 '25 00:12 changeset-bot[bot]