workers-sdk
workers-sdk copied to clipboard
Support Vike in autoconfig
Fixes https://jira.cfdata.org/browse/DEVX-2371
[!Note] Currently blocked by https://github.com/netlify/build/pull/6822
- Tests
- [x] Tests included/updated
- [ ] Tests not necessary because:
- Public documentation
- [ ] Cloudflare docs PR(s):
- [x] Documentation not necessary because: tracked elsewhere
- Wrangler V3 Backport
- [ ] Wrangler PR:
- [x] Not necessary because: autoconfig is not in v3
🦋 Changeset detected
Latest commit: 8944c7784e4e0e0f1c7202b50d8edd208876b41c
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
create-cloudflare
npm i https://pkg.pr.new/create-cloudflare@11549
@cloudflare/kv-asset-handler
npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11549
miniflare
npm i https://pkg.pr.new/miniflare@11549
@cloudflare/pages-shared
npm i https://pkg.pr.new/@cloudflare/pages-shared@11549
@cloudflare/unenv-preset
npm i https://pkg.pr.new/@cloudflare/unenv-preset@11549
@cloudflare/vite-plugin
npm i https://pkg.pr.new/@cloudflare/vite-plugin@11549
@cloudflare/vitest-pool-workers
npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11549
@cloudflare/workers-editor-shared
npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11549
@cloudflare/workers-utils
npm i https://pkg.pr.new/@cloudflare/workers-utils@11549
wrangler
npm i https://pkg.pr.new/wrangler@11549
commit: 8944c77
Claude finished @dario-piotrowicz's task —— View job
Changeset Review
⚠️ Issues found
Both changeset files need improvement:
.changeset/big-crabs-agree.md (create-cloudflare)
- ❌ Missing usage example: The description "Support Vike in
--experimentalmode" is too brief - According to
.changeset/README.md, new features should include examples showing users how to use the functionality - Should explain what
--experimentalmode means and provide a command example
.changeset/tiny-tires-write.md (wrangler)
- ❌ Missing usage example: The description "Support Vike in autoconfig" is too brief
- Should explain what autoconfig does for Vike projects
- Should include an example of how users will experience this (e.g., what happens when they run
wrangler deployin a Vike project)
What's correct ✅
- Version types: Both use
minor(correct for new features) - No major version bump for wrangler
- No forbidden markdown headers (h1/h2/h3)
Suggested improvements
For big-crabs-agree.md:
---
"create-cloudflare": minor
---
Support Vike in `--experimental` mode
You can now use C3 to scaffold Vike projects with Cloudflare integration:
\`\`\`bash
pnpm create cloudflare --experimental vike my-vike-app
\`\`\`
This creates a Vike project configured for deployment to Cloudflare Pages.
For tiny-tires-write.md:
---
"wrangler": minor
---
Support Vike in autoconfig
Wrangler now automatically detects and configures Vike projects for deployment. When you run `wrangler deploy` in a Vike project, the necessary build commands and compatibility settings are automatically configured without requiring manual wrangler.toml configuration.