[v3 backport] Expand #11138 to include changes from #11346: turn on tail logs by default
Expands the existing backport PR #11138 (which backported PR #11135) to also include the changes from PR #11346, which turns on tail-based logging by default for wrangler dev --remote.
Changes Overview
This PR builds on top of the existing tail-based logging implementation in #11138 by:
-
Enabling tail logs by default: Changed the
--experimental-tail-logsflag default fromfalsetotruein:packages/wrangler/src/dev.tspackages/wrangler/src/api/dev.tspackages/wrangler/src/pages/dev.ts
-
Hiding the experimental flag: Added
hidden: trueto the--experimental-tail-logsflag since it's now the default behavior -
Updated e2e tests: Removed the
--x-tail-logsflag from e2e tests inpackages/wrangler/e2e/dev-with-resources.test.tssince tail logs are now enabled by default -
Added changeset: Created a minor changeset documenting the behavior change and migration path
Important Notes
ProxyController changes from PR #11346 were NOT applied because they depend on a shouldConnectInspector() method that doesn't exist in v3-maintenance. This method was added in a v4-only PR and the changes are not applicable to v3. The v3 branch has different inspector handling logic.
Unrelated .gitignore files: The diff includes many .gitignore files added to packages/create-cloudflare/templates/. These appear to be from a previous commit in the backport branch and are unrelated to the tail logs changes. These should be reviewed to determine if they should be included or removed.
Human Review Checklist
Critical items:
-
🚨 Unrelated files: Review the .gitignore files in
packages/create-cloudflare/templates/- are these intentional or should they be removed from this PR? -
🚨 Runtime testing required: This PR was validated with
pnpm checkandpnpm fixbut was NOT runtime tested with actualwrangler dev --remotein a v3 environment. Please test:- Tail logs are received and printed correctly by default
--no-x-tail-logsflag works to revert to inspector-based logging- No inspector errors when tail logs are enabled
-
Changeset classification: The changeset is marked as "minor" but this changes default behavior significantly (removes inspector access by default). Should this be "major" instead?
-
ProxyController changes: Confirm that NOT applying the ProxyController changes from PR #11346 is correct for v3 (the
shouldConnectInspector()method doesn't exist in v3-maintenance) -
Breaking change impact: This removes devtools inspector access by default for
wrangler dev --remote. Users can revert with--no-x-tail-logsbut this is a significant behavior change. Is this acceptable for v3? -
CI expectation: The "v3 Maintenance / Is original PR merged" CI check will fail until PR #11346 is merged to main. This is expected and should be ignored until the original PR merges.
Link to Devin run: https://app.devin.ai/sessions/36ad59da2aaa401486ae453a5710a10c
Requested by: [email protected]
- Tests
- [x] Tests included (inherited from original PRs #11135 and #11346)
- [x] E2E tests updated to remove
--x-tail-logsflag
- Wrangler E2E Tests CI Job required?
- [x] Required - should test with default tail logs behavior in remote mode
- Public documentation
- [ ] Documentation not necessary because: v3 backport, behavior documented in changeset
- Wrangler V3 Backport
- [x] This IS the v3 backport of PRs #11135 and #11346
🤖 Devin AI Engineer
I'll be helping with this pull request! Here's what you should know:
✅ I will automatically:
- Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
- Look at CI failures and help fix them
Note: I can only respond to comments from users who have write access to this repository.
⚙️ Control Options:
- [ ] Disable automatic comment and CI monitoring
🦋 Changeset detected
Latest commit: b4780dc81c843fe5685687b51df6ce0049eaaf34
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 3 packages
| Name | Type |
|---|---|
| wrangler | Minor |
| miniflare | Patch |
| @cloudflare/pages-shared | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Devin can you try drafting this PR from scratch? Make sure to include the changes from the two tail-based logging PRs
❌ Cannot revive Devin session - the session is too old. Please start a new session instead.