workers-sdk icon indicating copy to clipboard operation
workers-sdk copied to clipboard

move the `debug` alias from the node hybrid plugin to unenv

Open vicb opened this issue 2 months ago • 5 comments

IMO it's better to move the alias back to unenv.

Two main reasons:

  • Easier to understand if aliases are not spread across unenv, the cloudfalre preset, and the hybrid plugin
  • Both Vite and wrangler/esbuild are using unenv so it's better to factor things there (note that Vite is not using the npm shims at the moment).

Context: the latest release of unenv rewrites the shim for the debug package and I was trying to understand how that would affect us. It will not as both wrangler and Vite use the original package rather than the shim.


  • Tests
    • [ ] Tests included
    • [x] Tests not necessary because: this is a refactoring and there are already tests to cover the behaviour.
  • Public documentation
    • [ ] Cloudflare docs PR(s):
    • [x] Documentation not necessary because: no user facing change
  • Wrangler V3 Backport
    • [ ] Wrangler PR:
    • [x] Not necessary because: unenv changes are not backported

vicb avatar Oct 24 '25 07:10 vicb

🦋 Changeset detected

Latest commit: 8ed3f90a916781510307180eef1514666b5d9641

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 24 '25 07:10 changeset-bot[bot]

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main vicb/unenv-debug might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-11079
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

github-actions[bot] avatar Oct 24 '25 07:10 github-actions[bot]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11079
@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11079
miniflare

npm i https://pkg.pr.new/miniflare@11079
@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11079
@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11079
@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11079
@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11079
@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11079
@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11079
wrangler

npm i https://pkg.pr.new/wrangler@11079

commit: 8ed3f90

pkg-pr-new[bot] avatar Oct 24 '25 07:10 pkg-pr-new[bot]

Appears to have broken the vite node.js tests

petebacondarwin avatar Oct 24 '25 07:10 petebacondarwin

force pushed to rebase on top of #11083

vicb avatar Oct 24 '25 12:10 vicb