workers-rs icon indicating copy to clipboard operation
workers-rs copied to clipboard

[Feature] use `http::Method` instead of re-implementing `Method`.

Open mendess opened this issue 1 year ago • 1 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Description

This crate implements it's own method type instead of using the more ecosystem standard http::Method. This makes it harder to integrate with reqwest_wasm and other crates that make use of the http::Method type.

Changing this now is a breaking change, which is annoying but I think it's worth it in the long run. Specially since http has just reached 1.0! A non breaking alternative would be to add two from implementations in order to make the conversion easier.

impl From<http::Method> for Method {}
impl From<Method> for http::Method {}

What do you think?

mendess avatar Dec 20 '23 18:12 mendess

Yeah, and it can not create custom Method, which makes it completely impractical when I want to build webdav.

Maybe someone knows?

fwqaaq avatar Dec 24 '23 06:12 fwqaaq

Fixed in #477

kflansburg avatar Mar 15 '24 15:03 kflansburg