workers-rs icon indicating copy to clipboard operation
workers-rs copied to clipboard

fix: worker-build not working on windows

Open zebp opened this issue 2 years ago • 3 comments

zebp avatar Sep 19 '22 14:09 zebp

I gave your change a whirl on my local as I'm a Windows user, and have been struggling to build a worker.

wasm-pack wouldn't install due to openssl, but I worked around that via the provided installer at https://rustwasm.github.io/wasm-pack/installer/.

Next up was worker-build not finding that version of wasm-pack. I tried this change, but it still doesn't manage to find it.

Since I know my local is installed, I ended up just forcing the function to return Ok(()) for now to get things rolling.

devnought avatar Sep 19 '22 22:09 devnought

I gave your change a whirl on my local as I'm a Windows user, and have been struggling to build a worker.

wasm-pack wouldn't install due to openssl, but I worked around that via the provided installer at https://rustwasm.github.io/wasm-pack/installer/.

Next up was worker-build not finding that version of wasm-pack. I tried this change, but it still doesn't manage to find it.

Since I know my local is installed, I ended up just forcing the function to return Ok(()) for now to get things rolling.

Sadly OpenSSL's weirdness is out of scope for this PR, you probably need to use vc-pkg to get the OpenSSL headers so it can be build via Cargo. That's what I did and it was worked fine.

zebp avatar Sep 20 '22 00:09 zebp

I agree that's out of scope, just wanted to voice that bit of frustration :)

But I did want to let you know that even with this change, worker-builder still cannot find wasm-pack on my Windows machine.

devnought avatar Sep 20 '22 01:09 devnought

@devnought I'm having issues with this now. How did you manage to get it to work?

jsomeara avatar Dec 28 '22 08:12 jsomeara