workerd icon indicating copy to clipboard operation
workerd copied to clipboard

Published 20 hours ago • verified publisher icon cloudflare

Implements buffering in HtmlRewriter.

Open dom96 opened this issue 2 years ago • 4 comments

Test plan and further details in internal PR number 4445.

dom96 avatar Oct 05 '22 17:10 dom96

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

github-actions[bot] avatar Oct 05 '22 17:10 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

dom96 avatar Oct 05 '22 17:10 dom96

Regarding header organization, would a separate html-rewriter-impl.h that gets included by both html-rewriter.c++ and the test work? That would keep the current header focused on the JS API as much as possible.

harrishancock avatar Oct 06 '22 15:10 harrishancock

Maybe @jasnell has an idea how hard converting HTMLRewriter to use the high-level Streams API might be?

Good question. Short answer is I don't know yet. Will have to tease that out a bit to get an idea.

jasnell avatar Oct 10 '22 19:10 jasnell