workerd icon indicating copy to clipboard operation
workerd copied to clipboard

Run V8's code formatter on patches.

Open erikcorry opened this issue 2 months ago • 4 comments

V8 uses 'git cl format' to autoformat C++ and other languages. It's easier to work with our patches if they are also formatted this way.

erikcorry avatar Dec 03 '25 10:12 erikcorry

CodSpeed Performance Report

Merging #5632 will improve performances by 13.19%

Comparing erikcorry/git-cl-format (10deaab) with main (903cdf1)

Summary

⚡ 1 improvement
✅ 56 untouched
⏩ 30 skipped[^skipped]

Benchmarks breakdown

Benchmark BASE HEAD Change
Encode_ASCII_32[TextEncoder][0/0/32] 3.4 ms 3 ms +13.19%
[^skipped]: 30 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

codspeed-hq[bot] avatar Dec 03 '25 13:12 codspeed-hq[bot]

Might be good to add this as a step in the v8.md/v8-updates.md docs in both this and the internal repo as a reminder

jasnell avatar Dec 03 '25 15:12 jasnell

to address the CI failure here: https://github.com/cloudflare/workerd/pull/5635

jasnell avatar Dec 03 '25 16:12 jasnell

If you rebase from main you'll pick up the CI fix.

jasnell avatar Dec 03 '25 18:12 jasnell