workerd icon indicating copy to clipboard operation
workerd copied to clipboard

fix several streams web-platform tests

Open anonrig opened this issue 2 months ago • 4 comments

Fixes several streams web-platform tests

anonrig avatar Dec 01 '25 16:12 anonrig

This fix does exactly what the WPT tests want. Do you think it could break anything else though - I just don't trust floats lol

npaun avatar Dec 01 '25 16:12 npaun

This fix does exactly what the WPT tests want. Do you think it could break anything else though - I just don't trust floats lol

It seems this fixes more than I've anticipated. Pushing soon...

anonrig avatar Dec 01 '25 16:12 anonrig

Please hold off on merging this. I want to evaluate a couple things here first. Want to see if we can reduce the number of changes in this as I'm not all that happy changing all of the size_ts to doubles.

jasnell avatar Dec 01 '25 16:12 jasnell

The generated output of @cloudflare/workers-types has been changed by this PR. If this is intentional, run just generate-types to update the snapshot. Alternatively, you can download the full generated types:

Full Type Diff
diff -r types/generated-snapshot/latest/index.d.ts bazel-bin/types/definitions/latest/index.d.ts
2500c2500
<   highWaterMark?: number | bigint;
---
>   highWaterMark?: number;
diff -r types/generated-snapshot/latest/index.ts bazel-bin/types/definitions/latest/index.ts
2508c2508
<   highWaterMark?: number | bigint;
---
>   highWaterMark?: number;

github-actions[bot] avatar Dec 01 '25 17:12 github-actions[bot]