workerd icon indicating copy to clipboard operation
workerd copied to clipboard

Build: replace angled-include with quotes-include to fix build.

Open balusch opened this issue 2 years ago • 3 comments

The compiler complains while building:

src/workerd/jsg/setup.c++:16:10: error: 'icudata-embed.capnp.h' file not found with include; use "quotes" instead #include <icudata-embed.capnp.h> ^~~~~~~~~~~~~~~~~~~~~~~ "icudata-embed.capnp.h" 1 error generated.

Signed-off-by: Jianyong Chen [email protected]

balusch avatar Sep 28 '22 13:09 balusch

Failed to build the project with command bazel build -c opt //src/workerd/server:workerd on my Arch Linux(5.19.11, clang 14).

It seems that icudata-embed.capnp.h(which is a file that generated by the Cap'n Proto compiler and put into the bazel-bin dir) is not in the search path.

balusch avatar Sep 28 '22 13:09 balusch

Hmm, this is weird. Angle includes seem correct to me (since the file is not in the same directory as the includer), and as-is it seems to have worked for lots of people... why does it not work in your case?

kentonv avatar Sep 30 '22 02:09 kentonv

Yes,pretty weird. And it seems that the problem only occurs on my computer, maybe something wrong in my environment configurations.

balusch avatar Oct 14 '22 10:10 balusch

Closing this because it seems to work as-is for most people, and we don't know exactly why it doesn't work for you. If we could figure out why, then we can reconsider whether this is the right fix.

kentonv avatar Dec 06 '22 16:12 kentonv

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

github-actions[bot] avatar Dec 06 '22 16:12 github-actions[bot]