workerd icon indicating copy to clipboard operation
workerd copied to clipboard

Add tests for workers-types that run in CI

Open Cherry opened this issue 5 months ago • 1 comments

Over the last year or so, there have been regular regressions or issues with workers-types that would have been caught with some testing and/or better vetting.

workers-types is a huge cornerstone in the Cloudflare Workers development experience, with TypeScript being the recommended language across the docs, npm create cloudflare, etc. It would be really good to see this have a much more first-class experience and release/vetting process.

Examples:

  • https://github.com/cloudflare/workerd/issues/2765
  • https://github.com/cloudflare/workerd/issues/2174
  • https://github.com/cloudflare/workerd/issues/1818
  • https://github.com/cloudflare/workerd/issues/2211
  • https://github.com/cloudflare/workerd/issues/2652

There do appear to be some tests created in https://github.com/cloudflare/workerd/tree/main/types/test, but I'm not sure how often these run, or if they run in CI, or how much coverage they provide? It would be really nice if these ran regularly and perhaps even a diff of types changes were added into PRs so the types output can be analysed quickly and easily.

Cherry avatar Sep 21 '24 14:09 Cherry