workerd icon indicating copy to clipboard operation
workerd copied to clipboard

Implement support for JS-backed WritableStreams in JSRPC

Open jasnell opened this issue 1 year ago • 1 comments

First pass at implementing support for JS-backed WritableStreams with JSRPC.

Provides an alternative adapter that will acquire the isolate lock on each write/close call, passing the operation off to the JS interface. This is obviously not as efficient as the original adapter used for WritableStreamSink but not yet sure if there's a better approach.

jasnell avatar Apr 26 '24 22:04 jasnell

@kentonv ...this should be ready for review!

jasnell avatar May 06 '24 18:05 jasnell

Reminder that GitHub loses information about force-pushes when you do two in a row which makes it hard to incrementally review. I think I've figured out that this diff represents the changes since I last reviewed, but in the future can you please post a list of fixup commits? The fixup.sh script in the internal repo generates such a list automatically if you use it.

kentonv avatar May 24 '24 15:05 kentonv