workerd icon indicating copy to clipboard operation
workerd copied to clipboard

Feature Request: version metadata `message` property

Open DaniFoldi opened this issue 10 months ago • 3 comments

Hi :wave:,

The workers logpush dataset contains a new scriptVersion object with three properties: id, message and tag (ref: https://developers.cloudflare.com/workers/configuration/versions-and-deployments/gradual-deployments/#logpush).

The binding however only contains id and tag. Is that an intentional choice, or could we get message added to it as well? Ref https://workers-types.pages.dev/#WorkerVersionMetadata from https://github.com/cloudflare/workerd/blob/789638f0ef63e485ec03cfee13672cce10abff11/types/defines/versions.d.ts#L5-L10

In my testing, it appears that message is indeed missing from the binding: https://version-metadata-binding.danifoldi.workers.dev/, so it's not just a missing type declaration

DaniFoldi avatar Apr 07 '24 10:04 DaniFoldi

@tanushree-sharma

irvinebroque avatar Aug 21 '24 19:08 irvinebroque

Thanks for reporting! I've added a ticket internally (WC-2620) to track this work, though transparently we won't be able to get to it until Q4 at the earliest.

Curious about how you're using this binding?

tanushree-sharma avatar Aug 23 '24 21:08 tanushree-sharma

We use id as a resource attribute in OpenTelemetry so if an update breaks something we can detect statistically significant changes in error rate that correlate to a new version

DaniFoldi avatar Aug 23 '24 21:08 DaniFoldi