workerd icon indicating copy to clipboard operation
workerd copied to clipboard

Add 2024-03-26 entry point to workers-types

Open IgorMinar opened this issue 1 year ago • 7 comments

adding a new entry point since the last one is from July 2023

IgorMinar avatar Mar 27 '24 00:03 IgorMinar

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

github-actions[bot] avatar Mar 27 '24 00:03 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

IgorMinar avatar Mar 27 '24 00:03 IgorMinar

recheck

IgorMinar avatar Mar 27 '24 00:03 IgorMinar

Note that RPC is scheduled for 2024-04-03. Will we be able to add another entrypoint next week?

kentonv avatar Mar 27 '24 22:03 kentonv

I see, I suggest that we then wait and release the 2024-04-03 entrypoint instead. (There is a cost to having too many entrypoints as it bloats the npm package.)

IgorMinar avatar Mar 28 '24 23:03 IgorMinar

Will we be able to add another entrypoint next week?

We shouldn't actually need to cut a new date for them. Whilst calling RPC methods on the client requires the rpc flag and new compat date, AFAIK using the classes from cloudflare:workers doesn't, and so these types should be accessible regardless of your compat date. Arguably the Fetcher/Service/DurableObjectNamespace types shouldn't accept a type parameter with the old compat date, but this probably doesn't matter too much.

mrbbot avatar Mar 28 '24 23:03 mrbbot

Oh good point... Yeah, the "rpc" compat flag doesn't actually impact the types at all.

kentonv avatar Mar 29 '24 17:03 kentonv