workerd Python snapshots: Add workerd cli options to save memory snapshots to disk

Python snapshots: Add workerd cli options to save memory snapshots to disk

Open hoodmane opened this issue 11 months ago • 5 comments

Mar 22 '24 14:03 hoodmane

Since this doesn't affect production, is an autogate actually necessary? Autogates exist for the purpose of rolling things out to production.

Maybe this behavior should be enabled by something in workerd/server/server.c++ instead?

Mar 22 '24 18:03 kentonv

@kentonv This makes sense, are there other development-only features that I could look at for inspiration?

Mar 25 '24 11:03 hoodmane

are there other development-only features that I could look at for inspiration?

Perhaps durableObjectStorage in workerd.capnp? Configures local disk storage for durable objects.

Mar 25 '24 16:03 kentonv

Seems like there's some overlap with #1851. Can you take a look?

Specifically, is there a possibility to reuse the DiskCache to store snapshots as well?

Mar 26 '24 19:03 garrettgu10

is there a possibility to reuse the DiskCache to store snapshots as well?

Yeah, this would make a lot of sense.

Mar 27 '24 20:03 hoodmane