workerd icon indicating copy to clipboard operation
workerd copied to clipboard

Coalesce reads in Actor Cache flush

Open MellowYarker opened this issue 11 months ago • 5 comments

MellowYarker avatar Mar 12 '24 19:03 MellowYarker

Exciting! Let me know if/when you'd like me to take a look at this.

a-robinson avatar Mar 12 '24 21:03 a-robinson

Exciting! Let me know if/when you'd like me to take a look at this.

There's still 1 failing test (ActorCache list stream cancellation) but definitely feel free to read through @a-robinson. Admittedly my commits could probably just be fixups on Ben's but I felt it was better to append than overwrite since I wasn't familiar with the code.

I just tossed in one more commit to try and (at least partially) fix that failing test, but it doesn't seem to be doing much. Other than that, I think I may try to add some more comments and do a bit more refactoring.

MellowYarker avatar Mar 12 '24 23:03 MellowYarker

https://github.com/cloudflare/workerd/compare/035450664ec894cc6d26540e096d7c4f612652fa..a529139f3b54dacedd1b6b77b0b3bebe2babc63d

^ tries to make it a bit easier to track when Entrys are added to the lists and when we're transitioning EntrySyncStatus states.

MellowYarker avatar Mar 14 '24 00:03 MellowYarker

https://github.com/cloudflare/workerd/compare/a529139f3b54dacedd1b6b77b0b3bebe2babc63d..4feb0f11e12a52065c9f38936ff165d4af9c622e was a rebase to fix conflicts. I accidentally pulled 1 extra commit so the second force push just gets us back to this feature branch on top of main.

MellowYarker avatar Mar 18 '24 15:03 MellowYarker

Just a partial review of the first handful of commits for now, sorry. I'll continue reviewing the rest, although have a couple questions that could use a response as well.

Thanks Alex, was hoping to get to some of the comments today but I noticed there was a new segfault. Thought something broke during the rebase, but it was just a bad commit. This took way longer to figure out than it should've :upside_down_face:

https://github.com/cloudflare/workerd/compare/d673ea074b7970362c48ea38034359757727c6c1..70a2d4637607cc2dc5028d723acd4dcaa975c20e

MellowYarker avatar Mar 19 '24 00:03 MellowYarker