terraform-provider-cloudflare icon indicating copy to clipboard operation
terraform-provider-cloudflare copied to clipboard

fix: cloudflare_workers_script run_worker_first accepts list input

Open maxwellpeterson opened this issue 7 months ago • 5 comments

  • [x] I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

  • Update assets.config.run_worker_first property of cloudflare_workers_script resource to accept list of strings in addition to boolean input
  • The Cloudflare API accepts both types of values, so this resource should support both

Additional context & links

Fixes #5956

maxwellpeterson avatar Sep 15 '25 16:09 maxwellpeterson

@aashishshrestha09 the bug you ran into was due to a mismatch between the attribute type within the model and schema. Sorry for the trouble here. This PR handles both boolean and string[] cases by using a Dynamic attribute capable of accepting both types.

1000hz avatar Sep 15 '25 17:09 1000hz

@aashishshrestha09 the bug you ran into was due to a mismatch between the attribute type within the model and schema. Sorry for the trouble here. This PR handles both boolean and string[] cases by using a Dynamic attribute capable of accepting both types.

Hi @1000hz,

Thank you for clarifying! That makes sense. Once this PR is merged, will the fix be available immediately in a v5.10.1 patch release, or will we need to wait for the next provider release (v5.11.0) to use it in Terraform?

Thanks again! Also, I’ve detected another issue with the assets block and have created a bug report here.

aashishshrestha09 avatar Sep 15 '25 17:09 aashishshrestha09

Can you target next please? And make sure its branched off next too.

vaishakdinesh avatar Sep 16 '25 18:09 vaishakdinesh

lgtm

vaishakdinesh avatar Nov 20 '25 05:11 vaishakdinesh

@maxwellpeterson Do we still need this? I think these changes are already in?

vaishakdinesh avatar Dec 05 '25 06:12 vaishakdinesh

Hey @maxwellpeterson I rebased your PR and it looks like there's no diff. I think other patches may have take care of this already maybe?

mgirouard avatar Dec 19 '25 19:12 mgirouard