terraform-provider-cloudflare icon indicating copy to clipboard operation
terraform-provider-cloudflare copied to clipboard

Depend explicitly on the challenge to prevent some errors

Open gdubicki opened this issue 10 months ago • 2 comments

like

"registry.terraform.io/cloudflare/cloudflare" produced an invalid new value
for .ownership_challenge: was null, but now cty.StringVal("[redacted]..[redacted]")

As recommended by @jacobbednarz in https://github.com/cloudflare/terraform-provider-cloudflare/issues/2752#issuecomment-1712190497

Workaround for issues like https://github.com/cloudflare/terraform-provider-cloudflare/issues/2794 https://github.com/cloudflare/terraform-provider-cloudflare/issues/2752 https://github.com/cloudflare/terraform-provider-cloudflare/issues/3001

gdubicki avatar Apr 22 '24 13:04 gdubicki

Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/contributing/changelog-process.md.

Example:

```release-note:TYPE
Release note
```

If you do not require a release note to be included and you have permission, please add the workflow/skip-changelog-entry label. Otherwise, a maintainer will add the label or ask you for one when they review the PR.

github-actions[bot] avatar Apr 22 '24 13:04 github-actions[bot]

👋 the data.aws_s3_bucket_object.challenge_file in the depends_on is redundant as the challenge_ownership value already references the datasource value. if you want to update that, we can get this merged

jacobbednarz avatar Apr 23 '24 02:04 jacobbednarz

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label. If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

github-actions[bot] avatar May 08 '24 00:05 github-actions[bot]

👋 the data.aws_s3_bucket_object.challenge_file in the depends_on is redundant as the challenge_ownership value already references the datasource value. if you want to update that, we can get this merged

Thanks, corrected that!

gdubicki avatar May 08 '24 11:05 gdubicki

thanks!

jacobbednarz avatar May 09 '24 02:05 jacobbednarz

This functionality has been released in v4.33.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions[bot] avatar May 15 '24 05:05 github-actions[bot]