terraform-provider-cloudflare icon indicating copy to clipboard operation
terraform-provider-cloudflare copied to clipboard

Add data source load balancer pools

Open wayt opened this issue 3 years ago • 2 comments

This adds a Data Source for Load Balancer Pools resources.

i.e:

data "cloudflare_load_balancer_pools" "pools" {
}

Since there is no actual filter on the API client, the data source doesn't offer any either.

⚠️ this is my first time contributing here, let me know if I missed any guidelines.

wayt avatar Sep 30 '21 15:09 wayt

thanks for solid start here @wayt, it's good! i've got some documentation i'm working on locally for PR minimums but for now, here is the tl;dr for this PR

  • website documentation is required (see other data source documentation for examples)
  • changelog note (see changelog-process)
  • passing tests which you've almost got here

jacobbednarz avatar Oct 01 '21 04:10 jacobbednarz

There we go, let me know if I missed anything @jacobbednarz

wayt avatar Oct 01 '21 14:10 wayt

@jacobbednarz I'd like to help on that PR, what's in your opinion the best way to contribute considering that it's been stalled for >1year?

xens avatar Dec 06 '22 13:12 xens

changelog detected :white_check_mark:

github-actions[bot] avatar Dec 09 '22 01:12 github-actions[bot]

@xens i've gone ahead and got this up to speed with the new conventions however, i'll have a play later this week to make sure it's working as expected. feel free to pull it locally and give it a whirl too.

jacobbednarz avatar Dec 09 '22 02:12 jacobbednarz

This functionality has been released in v3.30.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions[bot] avatar Dec 14 '22 04:12 github-actions[bot]