cloudflare
Parse Version Information Transport Parameter
Does not (yet!) incorporate parsed Version Information Transport Parameter into version negotiotiation.
@LPardue and @ghedo -- as usual, thank you both for this amazing implementation! I have added support for encoding/parsing the Version Information Transport Parameter. I realize there are additional changes that could be incorporated into this PR (namely, using the Version Information in the process of version negotiation) and I would be more than happy to talk that. But, I didn't want to get too far ahead in case this PR was unwelcome or you already had something planned.
If you think that what is here so far is reasonable and would like me to press on, just give me the nod! I would love to help however I can!
Thanks for the PR Will. I think its probably ok to parse the received TP for debug/analysis reasons. However, adding full version negotiation support is a bit more work and something that has no been a high priority for us.
It would probably be best to keep this PR focuses just on parsing received TPs and not provide an API to allow apps to set them (and hence no encoding). That would let us land the PR soonish. Then follow up work could consider a more-complete version negotiation approach, which will need lots of testing etc
Thanks for the PR Will. I think its probably ok to parse the received TP for debug/analysis reasons. However, adding full version negotiation support is a bit more work and something that has no been a high priority for us.
It would probably be best to keep this PR focuses just on parsing received TPs and not provide an API to allow apps to set them (and hence no encoding). That would let us land the PR soonish. Then follow up work could consider a more-complete version negotiation approach, which will need lots of testing etc
Funny that is your suggestion, because that is my preferred plan, too!! As you know, my use case is parsing TPs, so this will do exactly what I want. I will modify the PR (according to this plan and the helpful suggestion above) and resubmit!
Thanks, as usual!
I don't want to overstep, but if you would like me to add to the PR an update to the minimum supported Rust version (to solve this failure: 45b6494902ce0dc40fe8543f6d42f36385cd0e1e), I would be more than happy to do that!
I don't want to overstep, but if you would like me to add to the PR an update to the minimum supported Rust version (to solve this failure: 45b6494902ce0dc40fe8543f6d42f36385cd0e1e), I would be more than happy to do that!
Yeah a separate PR to bump th MSRV to 1.83.0 would be welcomed!
I don't want to overstep, but if you would like me to add to the PR an update to the minimum supported Rust version (to solve this failure: 45b6494902ce0dc40fe8543f6d42f36385cd0e1e), I would be more than happy to do that!
Yeah a separate PR to bump th MSRV to 1.83.0 would be welcomed!
Let me know if https://github.com/cloudflare/quiche/pull/2197 helps!