cloudflare
Add cwnd_unchecked congestion control algorithm
Copy the reno algorithm to cwnd_unchecked.rs, forcing congestion_window to 16GiB/2GiB (64/32bit) anytime it's manipulated in the reno algorithm creating an alteration of reno where the congestion window is unchecked
I'm a bit surprised about the amount of code in this PR. Why do we need to keep any cc logic at all inside the provided functions? To illustrate my point, consider a no-op cc algorithm I implemented in my own fork of quiche a few months ago (see diff), which looks much simpler. Am I missing something? I hope I'm not making a showcase of ignorance with my question...
I'm a bit surprised about the amount of code in this PR. Why do we need to keep any cc logic at all inside the provided functions? To illustrate my point, consider a no-op cc algorithm I implemented in my own fork of quiche a few months ago (see diff), which looks much simpler. Am I missing something? I hope I'm not making a showcase of ignorance with my question...
Agreed, seems like there seems to be too much implementation for a "disabled" CC... but maybe there is a good reason for that?
I'm a bit surprised about the amount of code in this PR. Why do we need to keep any cc logic at all inside the provided functions? To illustrate my point, consider a no-op cc algorithm I implemented in my own fork of quiche a few months ago (see diff), which looks much simpler. Am I missing something? I hope I'm not making a showcase of ignorance with my question...
This is what my team tried at first (very simple noop cc) but found that it eventually broke in production. This was before my time so I don't know if that would still be the case as this was 2.5 years ago but this version (or close to it) has been reliable in production so hesitant to change it too much
any update on this? would love to get it merged, as it would have immediate use for our use case.
