quiche icon indicating copy to clipboard operation
quiche copied to clipboard

Fix largest performance issue in profiler

Open catid opened this issue 1 year ago • 1 comments

I'm not great at writing Rust code, but this was an easy fix. In callgrind it was using 38% of the CPU time of the application, and afterwards 0.

catid avatar Aug 05 '24 01:08 catid

@catid Thanks for the PR. I'm not quite sure how you were profiling but it doesn't seem like there should really be an issue from the allocation alone. Instead, there's work that can be skipped entirely if there is nothing to read on the QPACK stream . I made https://github.com/cloudflare/quiche/pull/1841 to address that, maybe you'd like to recheck your numbers with that change?

LPardue avatar Sep 10 '24 14:09 LPardue