quiche icon indicating copy to clipboard operation
quiche copied to clipboard

CI: macOS M1 architecture

Open junhochoi opened this issue 1 year ago • 4 comments

Add macos-latest-xlarge target for building on Apple Sillicon macOS.

junhochoi avatar Nov 10 '23 01:11 junhochoi

This new job failed with:

The job was not started because recent account payments have failed or your spending limit needs to be increased. Please check the 'Billing & plans' section in your settings.

Probably because this m1 runner is paid one.

junhochoi avatar Nov 10 '23 01:11 junhochoi

This new job failed with:

The job was not started because recent account payments have failed or your spending limit needs to be increased. Please check the 'Billing & plans' section in your settings.

Probably because this m1 runner is paid one.

It works on my account : https://github.com/junhochoi/quiche/actions/runs/6819661072/job/18547366616 after increasing my Action limit (default 0 -> some $ amount) to run this.

And it's very fast!. Total time for macos-latest (Intel): 3m41s vs macos-latest-xlarge (m1): 1m14s (3x faster) (Yes faster probably because this is xlarge instance)

I'll let the maintainers to take a look since this PR needs a paid feature.

junhochoi avatar Nov 10 '23 01:11 junhochoi

You can use macos-14 now.

glandium avatar Feb 02 '24 07:02 glandium

You can use macos-14 now.

Thanks! I updated the PR to use macos-14. The build is green now.

Perf (build time) looks great.

  • macos-latest (x86_64): 5m3s
  • macos-14 (aarch64): 1m42s

junhochoi avatar Feb 02 '24 08:02 junhochoi

rebased.

junhochoi avatar Apr 09 '24 10:04 junhochoi

Sorry for the delay, this merged now, thanks @junhochoi!

ghedo avatar Apr 10 '24 11:04 ghedo