pingora icon indicating copy to clipboard operation
pingora copied to clipboard

`HttpPeer::new`. Return `Result<Self>` instead of `panic`

Open cospectrum opened this issue 9 months ago • 4 comments

Relates: https://github.com/cloudflare/pingora/issues/570

cospectrum avatar Mar 31 '25 10:03 cospectrum

sfv = "0" dependency breaks the build

cospectrum avatar Mar 31 '25 10:03 cospectrum

@cospectrum I'm curious to hear why you closed this PR. This is something we've also experienced in our production instance of Pingora (throwing a panic when an HttpPeer's DNS temporarily isn't resolving) Ideally this would be more Result-driven and our implementation of the proxy can choose what to do in this scenario (return a proper 502 error page, etc.)

matthewbjones avatar May 05 '25 15:05 matthewbjones

@cospectrum This looks reasonable. I don't think the documentation whitespace changes were intentional though?

drcaramelsyrup avatar May 21 '25 23:05 drcaramelsyrup

@drcaramelsyrup check this out ^

cospectrum avatar May 30 '25 16:05 cospectrum