pingora icon indicating copy to clipboard operation
pingora copied to clipboard

Add ResponseHeader in pingora_http crate's prelude

Open PeppyDays opened this issue 10 months ago • 3 comments

For import consistency, put ResponseHeader into pingora_http crate's prelude. This enables importing with use pingora::prelude::* to bring ResponseHeader and RequestHeader together.

Fixes https://github.com/cloudflare/pingora/issues/551.

PeppyDays avatar Mar 08 '25 06:03 PeppyDays

Oh, CI of Rust 1.82.0 has failed due to the security issue described https://rustsec.org/advisories/RUSTSEC-2024-0437.

I looked around the issue, and it comes from the protobuf crate that is dependency of prometheus crate. For now, there is no patched version of protobuf crate, and all versions of protobuf crate are affected. Maybe all the PRs from now on will fail until this issue resolves, and other crates has the similar issue as reported here.

As a workaround, I added the second commit to ignore RUSTSEC-2024-0437 during cargo audit.

PeppyDays avatar Mar 08 '25 07:03 PeppyDays

Awesome. I'll accept this change. We are putting out our own fix for the rust-sec issues. Can I get you to rebase after that?

johnhurt avatar Mar 14 '25 17:03 johnhurt

Awesome. I'll accept this change. We are putting out our own fix for the rust-sec issues. Can I get you to rebase after that?

I saw that the cargo-audit ignorance is applied in the main branch! So I removed the commit and rebased the current main just before. Please check it :)

PeppyDays avatar Mar 17 '25 15:03 PeppyDays

This was (finally) merged in https://github.com/cloudflare/pingora/commit/58e139e9f73bdedbf8e17344accc9a24ab6b2084, thank you for your contribution!

drcaramelsyrup avatar Dec 05 '25 21:12 drcaramelsyrup