pingora icon indicating copy to clipboard operation
pingora copied to clipboard

Fix h2 request_summary

Open Congyuwang opened this issue 1 year ago • 2 comments

Currently, HTTP/2 request_summary use HOST header for printing host, which is empty. While the path is also different from HTTP/1.x.

Before:

HTTP/1.x:

GET /, Host: example.com:8080

HTTP/2:

GET https://example.com:8080/, Host:

After this change: HTTP/2:

GET /, Host: example.com:8080

Congyuwang avatar Aug 05 '24 12:08 Congyuwang

The CI error is interesting, maybe unrelated to this PR but I encountered it also in my own work:

[2024-08-07T07:43:35Z WARN  pingora_core::protocols::http::v1::server] Respond header is already sent, cannot send again

This warning seems likely to be followed with Upstream broken pipe. I don't know if this is as expected, or likely a bug. If needed, I can file an issue about this.

Congyuwang avatar Aug 10 '24 02:08 Congyuwang

CI error looks like a flaky test. That warning is expected, it means an error occurred and since we already wrote response headers we cannot send them again with the error status.

andrewhavck avatar Aug 10 '24 15:08 andrewhavck

synced

Congyuwang avatar Aug 20 '24 15:08 Congyuwang