pingora icon indicating copy to clipboard operation
pingora copied to clipboard

Typo in https://blog.cloudflare.com/pingora-open-source: `UDP` should be `UDS`

Open yerke opened this issue 4 months ago • 0 comments

Describe the bug

First of all, congratulations on open sourcing Pingora and thank you for continuing to work on it!

In the linked blog post, you mention that Pingora works with UDP.

Pingora provides libraries and APIs to build services on top of HTTP/1 and HTTP/2, TLS, or just TCP/UDP.

I read relevant sections of Pingora source code, and I believe you made a typo. I think instead of UDP (User Datagram Protocol) you meant UDS (Unix domain socket). For example, HttpPeer can be constructed with TCP or UDS. Another example: SocketAddr is an enum over Inet(StdSockAddr) and Unix(StdUnixSockAddr).

Pingora info

N/A

Steps to reproduce

Search source for UDP and UDS.

Expected results

Find references to UDP.

Observed results

Only found references to UDS.

Additional context

N/A

yerke avatar Feb 29 '24 04:02 yerke