pingora icon indicating copy to clipboard operation
pingora copied to clipboard

Finish TODO: zip

Open cospectrum opened this issue 10 months ago • 3 comments

cospectrum avatar Apr 21 '24 22:04 cospectrum

~This looks like excellent work! There's a lot going on in this pr. My recommendation is to break it down in to a few smaller prs tackling one todo at a time. Also make sure your commit doesn't include changes to the .bleep file. That's our marker for keeping this repo in sync with our working copy.~

Edit. Oops, ignore the above. I think this commit just needs to be rebased on the new main branch. We had an issue last week where all the commits form contributors got squashed and we had to fix it manually. The actual code change here looks great 👍

johnhurt avatar Apr 26 '24 15:04 johnhurt

Rebased

cospectrum avatar Apr 26 '24 17:04 cospectrum

Love it. Thanks!

johnhurt avatar Apr 30 '24 19:04 johnhurt

Now available in https://github.com/cloudflare/pingora/commit/4347ef447183a66508c4de649a0657d1ce367dab. Thanks!

eaufavor avatar May 11 '24 00:05 eaufavor