lol-html icon indicating copy to clipboard operation
lol-html copied to clipboard

bring back lockfiles for bindings

Open selfisekai opened this issue 8 months ago • 1 comments

previously 9eb22a59fb39e318e73df37d90f6dce97fb9e13f removed Cargo.lock files citing https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries.

this argumentation is valid for the library as used from another rust/cargo project, but the C API produces a binary rather than a library (from the text's standpoint). I think similar with the JS API too.

(aside, maybe this repository should use cargo workspaces)

selfisekai avatar Nov 03 '23 08:11 selfisekai

Window height is iffy on Android, IMO don't trust it at all:

https://github.com/facebook/react-native/issues/23693

IDK if it's related, or if the react native team is ever going to fix this oneever. The best thing to do, IMO, is to just measure the root view yourself via onLayout and pass it via a context. It works on any device and is future proof.

iway1 avatar Aug 09 '22 19:08 iway1

this is still an issue

bryanltobing avatar Aug 27 '23 11:08 bryanltobing

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Feb 24 '24 05:02 github-actions[bot]

This issue was closed because it has been stalled for 7 days with no activity.

github-actions[bot] avatar Mar 05 '24 05:03 github-actions[bot]