helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

Add Configuration for Monitoring via Prometheus Operator

Open josephschadlick opened this issue 1 year ago • 3 comments

I noticed that https://github.com/cloudflare/helm-charts/pull/11 was created and subsequently closed due to a lack of sufficient metrics exposed in cloudflared.

Now that cloudflared supports a more useful set of metrics (described here), I would like to once again propose enabling configuration for metrics collection via a servicemonitor resource in both the cloudflare-tunnel and cloudflare-tunnel-remote charts.

josephschadlick avatar Aug 15 '23 21:08 josephschadlick

Is there any reason to use a service monitor rather than a pod monitor?

uhthomas avatar Aug 22 '23 14:08 uhthomas

Is there any reason to use a service monitor rather than a pod monitor?

Updated to use a PodMonitor instead. I have no strong opinion on which to use. ServiceMonitors seem more ubiquitous, but there is no need to manage a service for just this use case.

josephschadlick avatar Aug 22 '23 16:08 josephschadlick

I do prefer the service approach because of scaling and routing. I noticed that #57 did the "same thing" you did before moving from ServiceMonitor to PodMonitor.

lucasfcnunes avatar Nov 15 '23 18:11 lucasfcnunes

Please add also Grafana Dashboard ConfigMap

maxpain avatar Oct 13 '24 08:10 maxpain

any updates on this PR?

maxpain avatar Oct 13 '24 08:10 maxpain