goflow icon indicating copy to clipboard operation
goflow copied to clipboard

Remove remote_port label from flow_traffic metrics

Open slrtbtfs opened this issue 3 years ago • 3 comments

Fixes #94.

However it theoretically has the potential to break some existing usecases, where the distiction between remote ports is relevant.

Signed-off-by: Tobias Guggenmos [email protected]

slrtbtfs avatar Mar 22 '21 11:03 slrtbtfs

I was a bit alarmed by this, but the IOS-XR flow export we use does not randomize the source port regularly, may be even only on chassis reload. Still, this seems like a good precaution, I don't really see what you'd use that label for.

debugloop avatar Mar 22 '21 14:03 debugloop

Ping @lspgn. :smile: Any chance we can get some reviews and a release?

SuperQ avatar Apr 03 '21 13:04 SuperQ

Hello, Thank you for the PR, looks good to me. But I won't be able to merge yet (see #97). Thank you for your patience.

lspgn avatar Apr 03 '21 16:04 lspgn