cloudflared
cloudflared copied to clipboard
cloudflare
FTBFS due to quic-go not supporting go 1.20
Describe the bug cloudflared does not compile on go 1.20 due to the quic-go dependency specified in go.mod not supporting 1.20.
As of ~13 hours ago, 1.20 is supported upstream.
To Reproduce Compile with go 1.20 and it will fail with the following error:
# github.com/lucas-clemente/quic-go/internal/qtls
../pkg/mod/github.com/chungthuang/[email protected]/internal/qtls/go120.go:6:13: cannot use "The version of quic-go you're using can't be built on Go 1.20 yet. For more details, please see https://github.com/lucas-clemente/quic-go/wiki/quic-go-and-Go-versions." (untyped string constant "The version of quic-go you're using can't be built on Go 1.20 yet. F...) as int value in variable declarat
The dependency on quic-go should probably be updated sooner rather than later.
this is going to be extra tricky, since cloudflared does not use upstream quic-go, but a fork. would you accept a PR that changed to using the latest upstream quic-go release?
@mraerino : There's work being done on this. I'll tag in @bwesterb here.
We actually do use upstream quic-go, but replace the underlying qtls library. I prepared one for 1.20 yesterday, so it's ready to go.
cloudflared-2023.3.1 go version go1.20.2 darwin/arm64
github.com/lucas-clemente/quic-go/internal/qtls vendor/github.com/lucas-clemente/quic-go/internal/qtls/go120.go:6:13: cannot use "The version of quic-go you're using can't be built on Go 1.20 yet. For more details, please see https://github.com/lucas-clemente/quic-go/wiki/quic-go-and-Go-versions." (untyped string constant "The version of quic-go you're using can't be built on Go 1.20 yet. F...) as int value in variable declaration
FYI, go 1.21 will be released soon (see rc2 announcement), which will make go 1.19 not maintained anymore.
Successfully built cloudflared 2023.7.1 from source with go version go1.20.6 darwin/arm64
