cloudflare-typescript icon indicating copy to clipboard operation
cloudflare-typescript copied to clipboard

Punycode deprecation error in Node 21 and later

Open NGPixel opened this issue 11 months ago • 8 comments

In Node 21.x and later, using this library produces a deprecation warning because of your use of "punycode", via the node-fetch library.

Since you list Node 18.x as the oldest supported version of this library, you shouldn't be using node-fetch at all. Native fetch was added in 18.x.

Please remove the node-fetch dependency from this library and use fetch() directly instead.


In the meantime, users affected by this issue can add an override to their package.json as a workaround:

"overrides": {
  "whatwg-url": "^14.0.0"
}

NGPixel avatar Dec 20 '24 05:12 NGPixel

This issue hasn't been updated in a while. If it's still reproducing, please comment to let us know. Thank you!

github-actions[bot] avatar Mar 13 '25 16:03 github-actions[bot]

This is still reproducible and not stale. Please re-open and reconsider stalebot - closing open issues with automated tooling and no human review doesn't usually work very well in OSS in my experience. @jhutchings1

Cherry avatar Mar 20 '25 20:03 Cherry

Thanks for letting us know, @Cherry ! I reactivated this one, and I have responded in email as well. Happy to revisit the stalebot item. We had so many very old issues that I wanted to get a head start on triaging out the oldest ones. We're doing a new community triage process (details in the readme), and will have more discussions about these going forward. Thank you!

jhutchings1 avatar Mar 20 '25 22:03 jhutchings1

This issue hasn't been updated in a while. If it's still reproducing, please comment to let us know. Thank you!

github-actions[bot] avatar May 20 '25 16:05 github-actions[bot]

This issue hasn't been updated in a while. If it's still reproducing, please comment to let us know. Thank you!

github-actions[bot] avatar Jul 20 '25 16:07 github-actions[bot]

This is still an issue, don't close. And can https://nostalebots.xyz/ be considered please?

Cherry avatar Jul 20 '25 19:07 Cherry

This issue hasn't been updated in a while. If it's still reproducing, please comment to let us know. Thank you!

github-actions[bot] avatar Sep 20 '25 16:09 github-actions[bot]

The entire node shim can be removed. Something like https://github.com/cloudflare/cloudflare-typescript/compare/main...KhafraDev:cloudflare-typescript:remove-node-fetch maybe.

KhafraDev avatar Oct 06 '25 20:10 KhafraDev