cloudflare-rs icon indicating copy to clipboard operation
cloudflare-rs copied to clipboard

Published 20 hours ago • verified publisher icon cloudflare

Fix zone::ListZones endpoint

Open jbhannah opened this issue 5 years ago • 6 comments

Various fixes in the path of getting the ListZones endpoint to work correctly:

  • Use ListZonesParams for query in ListZones requests (fixes #75)
  • Fix fields that should be optional
  • Correctly deserialize empty plan frequency (fixes #8)

jbhannah avatar Feb 11 '20 21:02 jbhannah

@sssilver @jbhannah is there anything I can do to help speed this up? We're trying to get the ListZones endpoint working with our API and would really like to do it through this library. I'd be happy to help you get this up and running. Do let me know what I can do to help.

rakshith-ravi avatar Oct 21 '20 08:10 rakshith-ravi

Once the conflicts are resolved, I'll be happy to merge this.

sssilver avatar Feb 07 '21 15:02 sssilver

This would be taken care of by #124, wouldn't it?

rakshith-ravi avatar Feb 09 '21 06:02 rakshith-ravi

Yeah some of it would

On Tue, Feb 9, 2021 at 6:30 AM Rakshith Ravi [email protected] wrote:

This would be taken care of by #124 https://github.com/cloudflare/cloudflare-rs/pull/124, wouldn't it?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cloudflare/cloudflare-rs/pull/109#issuecomment-775705024, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEXKZR4KSFNWRFHWUVINJ3S6DJAXANCNFSM4KTJNJKQ .

sssilver avatar Feb 09 '21 15:02 sssilver

@sssilver - just saw this was rebased. is the plan to get it into the next release? If so, I'll hold on merging #165.

nilslice avatar Sep 16 '21 18:09 nilslice

@nilslice @sssilver It looks like my commit was included with #124 making this PR a no-op, so feel free to close it! Thanks! 😄

jbhannah avatar Sep 16 '21 20:09 jbhannah