cloudflare-php
cloudflare-php copied to clipboard
Adapter Interface should not enforce constructor
https://github.com/cloudflare/cloudflare-php/blob/master/src/Adapter/Adapter.php#L26
interface Adapter
{
/**
* Adapter constructor.
*
* @param Auth $auth
* @param string $baseURI
*/
public function __construct(Auth $auth, string $baseURI);
An interface should not enforce any constructor as this is an implementation-issue
In addition, it would be much nicer if the interface was the PSR interface (\Psr\Http\Client\ClientInterface
) so that we could use any Http client.