cloudflare-go icon indicating copy to clipboard operation
cloudflare-go copied to clipboard

Update QueueConsumer to reflect the API

Open 76creates opened this issue 1 year ago • 4 comments

Description

Hello team,

Im currently working on making https://github.com/cloudflare/terraform-provider-cloudflare/pull/3833 possible. Ive noticed that there are fields missing from the QueueConsumer and QueueConsumerSettings. Ive proceeded to add them, and also took consumer_id for Name input, which Im not sure is proper at the moment, Ill update if needed.

Please write to me for any additional changes needed, Im first time commiter on this repo.

Has your change been tested?

Ive tested it with the TF provider resources Im writing for the queue consumers.

Types of changes

What sort of change does your code introduce/modify?

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.
  • [ ] This change is using publicly documented in cloudflare/api-schemas and relies on stable APIs.

76creates avatar Sep 04 '24 18:09 76creates