cloudflare-gcp icon indicating copy to clipboard operation
cloudflare-gcp copied to clipboard

Feature/update cronjob name

Open Anticmos opened this issue 2 years ago • 5 comments

Hi!

As I was making use of this project I ran into a case where if I ran the deploy twice it would not always overwrite the previous CRON job and I also did not have enough control over the name of the cron job for subsequent runs.

This can cause confusion as GCP will just spit out:

ERROR: (gcloud.scheduler.jobs.create.pubsub) ALREADY_EXISTS: Job .../jobs/cf_logs_cron already exists.

Please take a look at the addition of a new variable!

Looking forward to feedback. Thanks!

Anticmos avatar Apr 27 '22 17:04 Anticmos

@shagamemnon Any thoughts?

Anticmos avatar Apr 30 '23 03:04 Anticmos

Thanks @Anticmos. Can you please create a default string value for the CRON_JOB_NAME in deploy.sh, for example:

# deploy.sh
CRON_JOB_NAME='cf_logs_cron'

shagamemnon avatar May 16 '23 00:05 shagamemnon

Hi @shagamemnon I believe it is already there: https://github.com/cloudflare/cloudflare-gcp/pull/103/files#diff-1c36d0bec3d940c4f51ce21b6d419a07cf300a86f1e6ac11f3b05a0df9a191eaR14

Anticmos avatar Jun 06 '23 03:06 Anticmos

@shagamemnon Any updates on this?

Anticmos avatar Jun 12 '23 19:06 Anticmos

@shagamemnon Any updates on this?

z

Anticmos avatar Mar 14 '24 18:03 Anticmos