cloudflare-docs icon indicating copy to clipboard operation
cloudflare-docs copied to clipboard

[Guide] get-started: new note of required subdomain for wrangler dev

Open nimeshnischal opened this issue 4 years ago • 5 comments
trafficstars

nimeshnischal avatar Oct 14 '21 04:10 nimeshnischal

Hey @nimeshnischal! Thank so much for the PR. Is there a particular problem you ran into here? I'm hesitant to merge it since you need to complete step 1 (registering an account) for most of the other steps to work. Let me know if there is a specific issue you ran into!

jkup avatar Oct 25 '21 21:10 jkup

Jon, I brought this up to Albert a few days ago. There have been many instances where users follow tutorials (for example Create React App - https://developers.cloudflare.com/workers/tutorials/deploy-a-react-app-with-create-react-app) and then cannot deploy due to a nondescript error which is resulted by this.

Example situation: https://discord.com/channels/595317990191398933/799437470004412476/899925648099905537

The error returned is simply Error code 10007: workers.api.error.script_error_not_found No indication there is no subdomain. This is something that should be fixed both in Wrangler and mentioned in tutorials in my opinion.

WalshyDev avatar Oct 25 '21 22:10 WalshyDev

@WalshyDev thank you for the additional context!

jkup avatar Oct 26 '21 02:10 jkup

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 7d3d958ba7e1005d201a7e62289737fd5d716394 config.toml View secret
- Generic High Entropy Secret 58b6333afd7670da52bd237bec6b2c0cb708ae5e products/ddos-protection/docs-config.js View secret
- Generic High Entropy Secret f5ad72dcb5f9b6b4072be76c18ee663e52f30f72 products/ddos-protection/docs-config.js View secret
3543783 Generic High Entropy Secret 51cbbada456648d933bd539e901cb20bb22d0adb products/ruleset-engine/docs-config.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

gitguardian[bot] avatar Jul 16 '22 22:07 gitguardian[bot]

This PR was opened before the developer doc site was moved to Cloudflare Pages. There are many conflicting branches. I'm going to close it now, but feel free to open a new issue or ask any questions.

KimJ15 avatar Jul 20 '22 17:07 KimJ15