cloudflare-docs icon indicating copy to clipboard operation
cloudflare-docs copied to clipboard

[KV] Wrangler-KV Command Update

Open Oxyjun opened this issue 1 year ago • 3 comments

Summary

Continuation of the PR from: https://github.com/cloudflare/cloudflare-docs/pull/15985

TLDR of this current PR:

  1. Centralising Wrangler-KV commands into partials/workers/wrangler-commands/kv.mdx. This is the single source of truth for Wrangler-KV commands.
  2. Referencing the KV commands in the "Commands" page in docs/workers/wrangler/commands.mdx.
  3. Referencing the KV commands in the "Commands" page in docs/kv/kv-commands.mdx.
  4. Previously, there were some small discrepancies in H4s between the two locations found in (2) and (3). This has been unified. Specifically, the content from docs/workers/wrangler/commands.mdx has been used over the other.

Screenshots (optional)

Documentation checklist

  • [x] The documentation style guide has been adhered to.
  • [ ] If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • [ ] Files which have changed name or location have been allocated redirects.

Oxyjun avatar Aug 22 '24 18:08 Oxyjun

There is currently one pending issue - when the "source of truth" KV commands are rendered in the list of all Wrangler commands, the table of headings on the RHS fails to register duplicated header names. There are several workarounds for this, but these changes need to be properly discussed with PCX.

Oxyjun avatar Aug 22 '24 18:08 Oxyjun

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3f93dc8
Status: ✅  Deploy successful!
Preview URL: https://d09fdaf1.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://kv-jun-wrangler-command-upda.cloudflare-docs-7ou.pages.dev

View logs

There is currently one pending issue - when the "source of truth" KV commands are rendered in the list of all Wrangler commands, the table of headings on the RHS fails to register duplicated header names. There are several workarounds for this, but these changes need to be properly discussed with PCX.

I think this has been solved, so good to merge?

thomasgauvin avatar Sep 04 '24 20:09 thomasgauvin