cfrpki icon indicating copy to clipboard operation
cfrpki copied to clipboard

Octorpki seems to be using a static user-agent

Open ties opened this issue 5 years ago • 1 comments

Hi,

When analysing HTTP access logs for a RRDP endpoint I noticed that all records for OctoRPKI have the same User-Agent

df_cf[['User-Agent', 'time']].head(1000).groupby(['User-Agent']).count().to_markdown()

User-Agent time
Cloudflare-RPKI-RRDP/1.0 (+https://rpki.cloudflare.com) 942
Cloudflare-RPKI-RRDP/1.0%20(+https://rpki.cloudflare.com) 58

It seems like the User-Agent is statically set in octorpki.go:1236. As a user doing an analysis of the adoption of newer versions of relying party software, in the future, it would help me if this header contained an indication of the version of OctoRPKI in use.

ties avatar Nov 11 '20 06:11 ties

Hi @ties, I will edit the code to make sure the current version is reflected. Thank you for raising the issue.

lspgn avatar Nov 11 '20 06:11 lspgn