cfrpki icon indicating copy to clipboard operation
cfrpki copied to clipboard

/infos returns a blank page

Open skakee opened this issue 4 years ago • 9 comments

Yesterday, 2020-10-06, I pulled the new versions of the binary with: go get -u github.com/cloudflare/cfrpki/cmd/octorpki
/infos returns with HTTP code 200 an a zero-byte json doc. /output.json and /metrics return fine. Running on CentOS 8.2: cloudfl+ 169753 1 3 Oct06 ? 00:33:17 /opt/cloudflare/go/bin/octorpki -mode server -output.sign=false -http.addr :8080

Any ideas as t why?

skakee avatar Oct 07 '20 13:10 skakee

Hi @skakee, Yes, I temporarily removed the endpoint in the alpha version. The idea is to refactor the API so it returns debugging information. It will come back. Let me know if you have any requests/suggestions on data to display.

lspgn avatar Oct 13 '20 21:10 lspgn

Thanks! That leads me to another question... if the available binary is "alpha", what is the recommended version I should run an how to obtain it? I'm running on CentOS 8.2. Thanks again.

P.S. I use /info to check for '"stable":true ' in Nagios monitoring.

skakee avatar Oct 13 '20 21:10 skakee

ah there's a new endpoint for this :/health. I am a bit late on improving the alpha version, there are some changes I want to integrate but haven't had time yet. The previous version should be fine: https://github.com/cloudflare/cfrpki/releases/tag/v1.1.4 (but is missing additions like Sentry and HTTPs TAL).

lspgn avatar Oct 13 '20 22:10 lspgn

Got it. Thanks!

skakee avatar Oct 13 '20 22:10 skakee

Hi! I just noticed that v1.1.4 is over a year old. Is this really the latest GA release? I know that there was a problem memory management you addressed since then. See: Octo-RPKI process RAM usage #37. That would imply that v1.1.4 still has memory usage issues. And I remember there was an issue with gortr holding on to TCP connections. Does version v0.14.6 on the release page of GoRTR fix that issue?

skakee avatar Oct 15 '20 14:10 skakee

Hello, Unfortunately, there have been time constrains which resulted in little changes during 2020. I was looking to fix #38, #66 and fix /infos before releasing 1.2.x. For the GoRTR bug you mentioned: it was fixed with https://github.com/cloudflare/gortr/commit/78f7a6e604c7c87ede67078aeee13a0d238cc51a which is included in 0.14.6.

Don't hesitate if you have more questions or concerns

lspgn avatar Oct 15 '20 17:10 lspgn

Thank you for the clarification. I will continue using my current version of octorpki and wait for an official release of the updated version. I am updating all our rpki servers' gortr to 0.14.6 (from current 0.14.4).

skakee avatar Oct 15 '20 19:10 skakee

Hi. Above you mention "ah there's a new endpoint for this :/health". Version v1.2.0-pre of the Linux binary also seems to return a blank page for /health.

skakee avatar Oct 29 '20 18:10 skakee

Health should return an empty, code 200 page and text/plain. It can be used by containers healthchecks. The v1.2.0 has the stable field back in /infos page. Let me know if that works for you.

lspgn avatar Oct 29 '20 22:10 lspgn